Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace htmltotext function #2436

Merged
merged 1 commit into from
May 24, 2023
Merged

Conversation

reneaaron
Copy link
Contributor

Describe the changes you have made in this PR

Replace the htmltotext function with DomParser to avoid JS injections.

htmlTotext("abc<svg><svg onload=alert(1)</svg></svg>123")

@github-actions
Copy link

🚀 Thanks for the pull request!

Here are the current build files for testing:

Download and unzip the file for your browser. Refer to the readme for detailed install instructions.


This build is brought to you by: channel.ninja (who recently dropped 1000 sats):


Want to sponsor the next build? send some sats to ⚡️builds@getalby.com (don't forget to provide your name)

Don't forget: keep earning sats!

@reneaaron reneaaron requested a review from im-adithya May 24, 2023 08:11
Copy link
Member

@im-adithya im-adithya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK 👍

@im-adithya im-adithya merged commit 606aedf into master May 24, 2023
5 of 6 checks passed
@im-adithya im-adithya deleted the fix/stackoverflow-htmltotext branch May 24, 2023 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants