Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: upgrade playwright #2454

Merged
merged 4 commits into from
Jun 6, 2023
Merged

fix: upgrade playwright #2454

merged 4 commits into from
Jun 6, 2023

Conversation

reneaaron
Copy link
Contributor

@reneaaron reneaaron commented May 29, 2023

Describe the changes you have made in this PR

Fix error in test runs caused by playwright and fixed upstream.

https://github.com/getAlby/lightning-browser-extension/pull/2447/checks

SystemError [ERR_SYSTEM_ERROR]: A system error occurred: uv_os_get_passwd returned ENOENT (no such file or directory)

After merging this we'll have our beloved timeout errors back. 🙈

@socket-security
Copy link

socket-security bot commented May 29, 2023

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been removed or ignored.

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@* or ignore all packages with @SocketSecurity ignore-all

@github-actions
Copy link

github-actions bot commented May 29, 2023

🚀 Thanks for the pull request!

Here are the current build files for testing:

Download and unzip the file for your browser. Refer to the readme for detailed install instructions.

Don't forget: keep earning sats!

@reneaaron reneaaron marked this pull request as ready for review May 30, 2023 21:43
@reneaaron reneaaron requested a review from im-adithya May 30, 2023 21:43
@im-adithya
Copy link
Member

I think you forgot to commit the package.json file

@reneaaron
Copy link
Contributor Author

@im-adithya Shouldn't really make a difference since versions are pinned in the lockfile, but updated it nevertheless.

@socket-security
Copy link

New and updated dependency changes detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives1 Size Publisher
@playwright/test ⬆️ 1.33.0...1.34.3 None +2/-2 13.8 MB aslushnikov

Footnotes

  1. https://docs.socket.dev

@reneaaron reneaaron merged commit 31d8255 into master Jun 6, 2023
5 of 6 checks passed
@reneaaron reneaaron deleted the fix/upgrade-playwright branch June 6, 2023 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants