Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disable signup via extension and link to web signup #2460

Merged
merged 3 commits into from
Jun 6, 2023

Conversation

rolznz
Copy link
Contributor

@rolznz rolznz commented Jun 2, 2023

Describe the changes you have made in this PR

Signups are currently disabled in the extension but users receive a hardcoded "invalid password" message. This change links the user to signup through the website instead.

Type of change

(Remove other not matching type)

  • fix: Bug fix (non-breaking change which fixes an issue)

Screenshots of the changes [optional]

image

How has this been tested?

Manually

Checklist

  • My code follows the style guidelines of this project and performed a self-review of my own code
  • New and existing tests pass locally with my changes
  • I checked if I need to make corresponding changes to the documentation (and made those changes if needed)

@github-actions
Copy link

github-actions bot commented Jun 2, 2023

🚀 Thanks for the pull request!

Here are the current build files for testing:

Download and unzip the file for your browser. Refer to the readme for detailed install instructions.

Don't forget: keep earning sats!

Copy link
Contributor

@reneaaron reneaaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some styles.

tACK

@reneaaron reneaaron merged commit d4bbde8 into master Jun 6, 2023
5 of 6 checks passed
@reneaaron reneaaron deleted the fix/disable-extension-signup branch June 6, 2023 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants