fix: update keyboard shortcut to mv3 #2546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The keyboard shortcut doesn't work for me in chrome (at least not with the dev build) 🤔 |
|
🚀 Thanks for the pull request! Here are the current build files for testing: Download and unzip the file for your browser. Refer to the readme for detailed install instructions. Don't forget: keep earning sats! |
|
does it work with this? |
|
No, only after setting it manually in the chrome settings: chrome://extensions/shortcuts Don't know if that is because this shortcut might already be used. |
|
there is a bug in chrome, https://bugs.chromium.org/p/chromium/issues/detail?id=1478453#c_ts1695708024 it works for firefox currently maybe we merge it for now. since it will take time to get this fix from their side |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the changes you have made in this PR
Action commands seem to have been moved with MV3:
https://developer.chrome.com/docs/extensions/reference/commands/#action-commands