feat: provider onboard #2701
Merged
feat: provider onboard #2701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pavanjoshi914 can you merge master? |
bumi
reviewed
Aug 29, 2023
src/extension/background-script/actions/onboard/providerOnboard.ts
Outdated
Show resolved
Hide resolved
signed-off-by: pavan joshi <pavanj914@gmail.com>
pavanjoshi914
force-pushed
the
nostr-key-prompt
branch
from
bc2d759
to
ff9148f
Compare
rolznz
reviewed
Aug 31, 2023
rolznz
reviewed
Aug 31, 2023
rolznz
reviewed
Aug 31, 2023
rolznz
reviewed
Aug 31, 2023
|
@rolznz we had a huddle to discuss potential flow of the process. so i quickly pushed commit to disucss things. code is not cleaned yet and contains many unnecessary things. making proper changes |
cleanup the code add onboarding to liquid and webbtc cleanup prompt util signed-off-by: pavan joshi <pavanj914@gmail.com>
pavanjoshi914
force-pushed
the
nostr-key-prompt
branch
from
cdb48e5
to
1785a07
Compare
|
@pavanjoshi914 can you link this PR to the original issue? |
rolznz
reviewed
Sep 1, 2023
src/extension/background-script/actions/onboard/providerOnboard.ts
Outdated
Show resolved
Hide resolved
rolznz
reviewed
Sep 1, 2023
rolznz
reviewed
Sep 1, 2023
bumi
reviewed
Sep 3, 2023
add comments use get account in listener function itself signed-off-by: pavan joshi <pavanj914@gmail.com>
pavanjoshi914
force-pushed
the
nostr-key-prompt
branch
from
7d17bf7
to
7eb92c3
Compare
rolznz
reviewed
Sep 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the changes you have made in this PR
onboard users for different providers such as liquid, nostr and webbtc
Fixes #2713
TODO:
all the todo's are done
Link this PR to an issue [optional]
Type of change
feat: New feature (non-breaking change which adds functionality)Screenshots of the changes [optional]
Add screenshots to make your changes easier to understand. You can also add a video here.
How has this been tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist