Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new receive ui #2722

Merged
merged 21 commits into from
Sep 13, 2023
Merged

feat: new receive ui #2722

merged 21 commits into from
Sep 13, 2023

Conversation

reneaaron
Copy link
Contributor

@reneaaron reneaaron commented Sep 5, 2023

Describe the changes you have made in this PR

Fixes #2659

Fixes #2366

package.json Show resolved Hide resolved
@socket-security
Copy link

socket-security bot commented Sep 5, 2023

New dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
tailwindcss-3d 1.0.0 None +2 527 kB sambauers

@rolznz
Copy link
Contributor

rolznz commented Sep 6, 2023

image

Should we update this to "Lightning Address Copied"?

I think the toast style will be improved in a different PR - would be nice to have dark mode styling there.

Also feels like the edges of the qr are a bit cut-off, but it still scans ok!

@reneaaron
Copy link
Contributor Author

reneaaron commented Sep 6, 2023

Should we update this to "Lightning Address Copied"?

I don't think it's worth maintaining separate translations for that. I think it's clear from the context what is put into your clipboard.

I think the toast style will be improved in a #2650 - would be nice to have dark mode styling there.

Yes, I'd love to get that merged ASAP, still facing some problems I need to sort out.

Also feels like the edges of the qr are a bit cut-off, but it still scans ok!

Yeah, I did that on purpose. 👍 Let's see if all QR-code scanners work with the inverted colors as well.

src/common/utils/helpers.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@rolznz rolznz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

@rolznz rolznz merged commit 503cbf5 into master Sep 13, 2023
7 checks passed
@rolznz rolznz deleted the feat/receive-revamp branch September 13, 2023 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Revamp Receive screen [Feature] Improve QR code colors in dark mode
2 participants