feat: new toasts 馃敟馃崬 #2729
Merged
feat: new toasts 馃敟馃崬 #2729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
New and removed dependencies detected. Learn more about Socket for GitHub 鈫楋笌
馃毊 Removed packages: react-toastify@9.1.3 |
|
Will the bottom always be well visible? on a bigger screen when I enter something at the top? |
|
How does the user close the toast right now? do we want/need that? |
rolznz
approved these changes
Sep 7, 2023
It's a fixed container, so yes.
They can't currently, the automatically go away after 4s (success) / 8s (error) unless there is a different duration defined. We could easily add that though... |
|
I've added a close icon for toasts that show longer than 10s. 馃憤 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the changes you have made in this PR
Screencast.from.2023-09-06.15.10.23.webm