Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: webln request supported methods check #2740

Merged
merged 4 commits into from
Sep 8, 2023

Conversation

rolznz
Copy link
Contributor

@rolznz rolznz commented Sep 8, 2023

Describe the changes you have made in this PR

webln.request always fails because provided method does not match supported methods (prefixed with request.)

Type of change

  • fix: Bug fix (non-breaking change which fixes an issue)

How has this been tested?

Manually, with webln sandbox (also needs a fix there)

Checklist

  • Self-review of changed code
  • Manual testing
  • Added automated tests where applicable
  • Update Docs & Guides
  • For UI-related changes
  • Darkmode
  • Responsive layout

Copy link
Contributor

@reneaaron reneaaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@reneaaron reneaaron merged commit 19dc37c into master Sep 8, 2023
5 of 6 checks passed
@reneaaron reneaaron deleted the fix/webln-request-supported-methods branch September 8, 2023 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants