feat: transaction list revamp #2744

reneaaron · 2023-09-08T12:24:00Z

Describe the changes you have made in this PR

transaction list revamp

Design

https://www.figma.com/file/IvlUHnC3vkIWnQ14FppZqT/%F0%9F%8E%A8-Extension-UI-revamp?node-id=101%3A62629&mode=dev

cleanup hooks and use single hook to get transactions cleanup allowanceview, homeview and publisher card view to adapt transaction list changes add mechanism to sort, db payments and invoices signed-off-by: pavan joshi <pavanjoshi914@gmail.com>

color sats word in transaction table using regex

rolznz · 2023-09-26T11:31:36Z

@pavanjoshi914 I get some NaN sats transactions

rolznz · 2023-09-26T11:32:43Z

@pavanjoshi914 can you please update the PR description and link to a ticket?

rolznz · 2023-09-26T11:35:09Z

Arrow icons do not match the figma (sizing and thickness), can they be updated?

src/app/hooks/useTransactions.ts

src/app/components/TransactionsTable/index.tsx

pavanjoshi914 · 2023-09-27T05:32:55Z

@pavanjoshi914 I get some NaN sats transactions

unable to reproduce this on my side. kindly check in production

pavanjoshi914 · 2023-09-27T05:33:46Z

Arrow icons do not match the figma (sizing and thickness), can they be updated?

bitcoin designs has only those icon, we need custom fat arrow icons if we want the icon similar to design. i didn't put much priority on icons currently

setup callback communication minor naming corrections shift publisher link in the transaction modal correct variable names, show total fees in form of formatted sats signed-off-by: pavan joshi <pavanj914@gmail.com>

…list

reneaaron · 2023-10-30T13:02:00Z

	Alby	Commando (core-lightning)	LNBits	LND	LNDHub
Incoming
- Empty	✅
- Memo	✅
- LNURLP Comment	✅
- Boostagram	✅
Outgoing
- Empty	✅
- Memo	✅

Other connectors currently have no support for displaying transactions.

reneaaron

Looks quite good so far, some feedback to address ⬇️

src/app/components/TransactionsTable/index.tsx

src/app/hooks/useTransactions.ts

src/extension/background-script/actions/ln/transactions.ts

src/extension/background-script/connectors/connector.interface.ts

src/i18n/locales/en/translation.json

src/types.ts

…list

…ghtning-browser-extension into feat/transaction-list

remove exposure of getInvoices via api fix broken show more button for lndhub signed-off-by: pavan joshi <pavanj914@gmail.com>

src/extension/background-script/actions/ln/transactions.ts

src/app/hooks/useTransactions.ts

src/extension/background-script/actions/ln/transactions.ts

src/extension/background-script/connectors/alby.ts

src/extension/background-script/connectors/commando.ts

reneaaron · 2023-11-06T11:09:22Z

remove unnecessary types at connectorlevel add proper types for internal methods cleanup connector getInvoices method which don't have getTransactions method

reneaaron · 2023-11-09T22:20:08Z

tACK

reneaaron and others added 12 commits September 26, 2023 15:04

feat: new transaction list

61e979e

fix: remove unused badges

598e356

fix: detail view

034afdb

modify transaction list heading and align it to center at all places

ae79520

feat: unify transaction list

b61b914

cleanup hooks and use single hook to get transactions cleanup allowanceview, homeview and publisher card view to adapt transaction list changes add mechanism to sort, db payments and invoices signed-off-by: pavan joshi <pavanjoshi914@gmail.com>

feat: redesign sats showcase

62b00ab

feat: keep sats word in the currencty converter itself

95ec2b0

color sats word in transaction table using regex

feat: add payment hash in transaction model

b96acbc

feat: add show more button

5e617df

feat: add boostagram details

80a5490

feat: cleanup regex keep same color for now

314febc

chore: resolve conflict

ce2980e

pavanjoshi914 force-pushed the feat/transaction-list branch from f44a241 to ce2980e Compare September 26, 2023 09:43

pavanjoshi914 marked this pull request as ready for review September 26, 2023 09:44