Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: signPSBT #2746

Merged
merged 32 commits into from Oct 9, 2023
Merged

feat: signPSBT #2746

merged 32 commits into from Oct 9, 2023

Conversation

rolznz
Copy link
Contributor

@rolznz rolznz commented Sep 11, 2023

  • use new bitcoin object and remove added lib functions. Use new liquid secp provider for signing
  • remove experimental webpack flag
  • review addition of new libraries
  • review inconsistency with liquid - here signPsbt actually uses hex, liquid uses base64. Hex seems more accepted for bitcoin tools and APIs.

Describe the changes you have made in this PR

Ability to sign partially signed bitcoin transactions

Test it at: https://getalby.github.io/bitcoin-wallet/

Type of change

(Remove other not matching type)

  • feat: New feature (non-breaking change which adds functionality)

Screenshots of the changes [optional]

image

image

Add screenshots to make your changes easier to understand. You can also add a video here.

How has this been tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist

  • Self-review of changed code
  • Manual testing
  • Added automated tests where applicable
  • Update Docs & Guides
  • For UI-related changes
  • Darkmode
  • Responsive layout

@rolznz rolznz self-assigned this Sep 11, 2023
@socket-security
Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
@bitcoinerlab/secp256k1 1.0.5 None +0 10.4 MB jl.landabaso

🚮 Removed packages: @scure/btc-signer@0.5.1

@reneaaron reneaaron changed the title Feat/signpsbt v2 feat: signPSBT Oct 4, 2023
Copy link
Contributor

@reneaaron reneaaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! 🚀

package.json Outdated Show resolved Hide resolved
src/extension/content-script/webbtc.js Outdated Show resolved Hide resolved
src/i18n/locales/en/translation.json Outdated Show resolved Hide resolved
@rolznz rolznz requested review from reneaaron and bumi October 9, 2023 07:50
Copy link
Contributor

@reneaaron reneaaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

Co-authored-by: René Aaron <100827540+reneaaron@users.noreply.github.com>
@rolznz rolznz enabled auto-merge October 9, 2023 14:59
@rolznz rolznz merged commit 929ba15 into master Oct 9, 2023
6 of 7 checks passed
@rolznz rolznz deleted the feat/signpsbt-v2 branch October 9, 2023 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants