feat: send message to all the valid tabs which has receiving end #2748
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the changes you have made in this PR
we query active tabs and iterate over them. if we have the tab that doesn't have the content script for such tab when we do postMessage. the error, receiving end does not exist will be thrown and we will get out of the function. this can lead to not notifying to active tabs
for eg. [tab not having content script, tab having content script]
tab having a content script is in the second place of the array. when we iterate and post message. we will get error for tab present in first position. and hence no notification logic will be executed for tab which is on second position of the array.
solution would be. handle errors inside for loop instead of top level function
Link this PR to an issue [optional]
Fixes #ISSUE-NUMBER
Type of change
(Remove other not matching type)
fix
: Bug fix (non-breaking change which fixes an issue)Checklist