Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add validation to the account name input field #2790

Merged
merged 1 commit into from Oct 3, 2023

Conversation

Rithvik-padma
Copy link
Contributor

Describe the changes you have made in this PR

Added the validation for not allowing empty account names using the required attribute.

Link this PR to an issue [optional]

Fixes #2528

Type of change

  • fix: Bug fix (non-breaking change which fixes an issue)

Screenshots of the changes [optional]

chrome_SxHzEGIXUw

How has this been tested?

tested manually by trying to save empty account name.

Checklist

  • Self-review of changed code
  • Manual testing

@Rithvik-padma
Copy link
Contributor Author

@rolnz I did not add any custom validation over here, I just added the required attribute.
I can add custom validation message if that is necessary.
Thanks!

Copy link
Contributor

@rolznz rolznz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@rolznz rolznz merged commit 0c52b82 into getAlby:master Oct 3, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Add validation for account names
2 participants