feat: custom locale switcher #2981
Conversation
src/app/router/Welcome/Welcome.tsx
Outdated
| @@ -64,7 +65,10 @@ function Layout() { | |||
| return ( | |||
| <div className="flex justify-center items-center min-h-screen"> | |||
| <div className="w-full"> | |||
| <div className="max-w-7xl mx-auto px-4 sm:px-6 lg:px-8 mb-4"> | |||
| <div className="absolute top-0 left-0 mt-4 ml-6 z-50"> | |||
There was a problem hiding this comment.
Don't use absolute positioning or add some proper paddings on the outer element that prevent overflowing on smaller screens.
Maybe center the dropdown on smaller screens?
|
true absolute positioning was a bad idea there. cause even if we scroll switcher will be visible and designs are not like that to support this. i changed layout with something else |
|
Can't test without built but tACK |
I am unclear about the behavior we want to achieve here! it really depends on the content as well right? for eg. if i surf extension in brasil lang i can see scrollbars. as text there is longer. locale switcher takes addditional space. even we adjust some content for en lang on other contents there will be still the scrollbars appearing |
video_2024-01-23_12-46-06.mp4 |
|
Sorry, I should have added a screenshot. The fullscreen page now always has scrollbars since the content of the page exceeds the available height.
|
|
resolved |
Describe the changes you have made in this PR
local switcher in onboardings screen
custom design to use it diffferent places
Link this PR to an issue [optional]
Fixes #2918
Type of change
(Remove other not matching type)
feat: New feature (non-breaking change which adds functionality)Screenshots of the changes [optional]
Checklist