Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logos to new account screen #349

Merged
merged 13 commits into from Dec 2, 2021

Conversation

secondl1ght
Copy link
Contributor

@secondl1ght secondl1ght commented Nov 3, 2021

Added logos for each node/wallet option when setting up a new account #315.

Screenshot:
image

I am open to any feedback and suggestions if anyone wants to change anything i've done here! :)

@dylancom
Copy link
Contributor

dylancom commented Nov 3, 2021

Cool, looks a lot better already.
Would say that the logo's of LNDHub & LNbits should be a bit more in balance with the other logo's (too big currently).
For the logo's I'd say we use SVG instead of .png?

@bumi
Copy link
Collaborator

bumi commented Nov 3, 2021

👍 for SVGs also adding @johnsBeharry for a UI review

@secondl1ght
Copy link
Contributor Author

Ok I have made them all the same size and converted from PNG to SVG. I found an online converter tool to do this, however it looks like some of the colors changed a bit when doing that. If anyone knows a better way to convert the images just let me know. Please let me know what you guys think of this iteration:

Screenshot:
image

@secondl1ght
Copy link
Contributor Author

Here's another version where the LND logo has a blue background:
image

@dylancom
Copy link
Contributor

dylancom commented Nov 4, 2021

I would prefer the logo's to appear without a background.

@bumi
Copy link
Collaborator

bumi commented Nov 4, 2021

converted from PNG to SVG.

do you know if these projects provide SVG version of the logo? those would have better quality and can easily be scaled then.

@secondl1ght
Copy link
Contributor Author

I'll look into finding the official SVGs for each project tonight. I agree that would be much better.

@secondl1ght
Copy link
Contributor Author

For our own Alby logo, do we have an SVG of that? I didn't see one in the assets folder.

@secondl1ght
Copy link
Contributor Author

So far I haven't had any luck finding SVGs for all the projects. I found one in the lnbits repo but did not see one in LNDhub or LND. I asked in the LND Slack group if there was an SVG icon for developers but did not get a response. I tried contacting the BlueWallet guys over e-mail and did not hear back yet either.

So for now we can either use PNGs with the correct colors or use the SVGs with the slight color variations from converting them. Or just wait to merge this PR until we can track down the official SVGs.

@secondl1ght
Copy link
Contributor Author

So it looks like not every project has an official SVG logo. I have changed this PR back to using the PNGs for now. My vote would be to use those rather than convert the logos and cause some distortions.

@secondl1ght
Copy link
Contributor Author

Here's another option for everyone to consider, I changed to the Blue Wallet logo as suggested by @MoritzKa and I also removed the forced rounding and let each logo have its own shape.

image

This one probably looks the best IMO but if we can agree on feedback then maybe we can merge.

I know @dylancom would like ones without background but with my limited design skills I haven't been able to make PNGs without backgrounds while also making them all appear the same size. Because a 200x200 image with no background will look smaller than one with a background. So if anyone else wants to send me some of their own images I can use those and post screenshots.

@MoritzKa
Copy link
Contributor

I wonder how to create a logo without background out of the LNbits logo for instance. The latest update is a great improvement for the extension. Let's ask for feedback in the community call and decide.

@secondl1ght
Copy link
Contributor Author

We didn't bring up this PR in today's meeting but is there anything anyone else wants me to do for this one?

@MoritzKa
Copy link
Contributor

It is a great improvement.
What do you think, @johnsBeharry ?

@secondl1ght
Copy link
Contributor Author

Ok @johnsBeharry was nice enough to provide some uniform images that we have been looking for. So now they are all the same size and look good, here's what the updated version looks like:

image

He also gave an alternative option for the Alby logo:

image

@secondl1ght
Copy link
Contributor Author

Johns also gave us a yellow version which I personally like better but we can take a vote on it:

image

@MoritzKa
Copy link
Contributor

I would also choose the yellow background for the logo. But the extension design is not final anyway.
So let's go with the full body Alby logo (not just head) on a white background.

@secondl1ght
Copy link
Contributor Author

Here's what that version looks like:

image

@bumi
Copy link
Collaborator

bumi commented Nov 24, 2021

I like it! @johnsBeharry can you review

@secondl1ght
Copy link
Contributor Author

Oh sorry I see everyone wants the white background, I just need Johns to put the white version back on dropbox and then I can make the final changes.

@bumi
Copy link
Collaborator

bumi commented Nov 25, 2021

ok, we need to merge the conflict and then get decide and get this in!

@johnsBeharry johnsBeharry added design frontend All things frontend development related labels Nov 26, 2021
@bumi
Copy link
Collaborator

bumi commented Nov 26, 2021

so it is very likely that we get the Galoy connector in and we should directly plan that we will have an icon for it

@secondl1ght
Copy link
Contributor Author

OK I have merged the conflicts, yep we can for sure add a Galoy logo as well. Maybe johns has one that is formatted the same as the others? Also the current version of this PR is using the yellow, full-body Alby logo just so everyone knows, but it can be changed still.

@bumi bumi merged commit 891fa16 into getAlby:master Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend All things frontend development related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants