Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change grid to allow 5 connectors per row #558

Merged
merged 1 commit into from Jan 31, 2022

Conversation

secondl1ght
Copy link
Contributor

@bumi wanted to have all on one row instead of having 1 connector by itself.

image

@bumi
Copy link
Collaborator

bumi commented Jan 24, 2022

whoot. you're fast.
@johnsBeharry are you OK with that. and then we think what do do once we have Galoy in?

@johnsBeharry
Copy link
Contributor

johnsBeharry commented Jan 25, 2022

We won't have Galoy, as that's just the tech from what I understand. So it will be BitcoinBeach, and I think Bitcoin Jungle. @vindard is that correct? OR do those two apps share a database?

Either way I reckon that list will continue to grow, and I'd opt we go for a more App Store style card. Similar to what Auwal did for the Websites tab.

Screenshot 2022-01-25 at 1 07 12 AM

@bumi
Copy link
Collaborator

bumi commented Jan 25, 2022

Check out the #434 branch. It is a Galoy connector.

I like the app store style cards...those can hold enough information.

@bumi
Copy link
Collaborator

bumi commented Jan 25, 2022

but are you OK with this PR for this release?

Copy link
Contributor

@johnsBeharry johnsBeharry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vindard
Copy link
Contributor

vindard commented Jan 25, 2022

So it will be BitcoinBeach, and I think Bitcoin Jungle

I guess tbd because the only thing that separates these two is the api link we point at.

@johnsBeharry
Copy link
Contributor

A Galoy connector in Alby would then need the user Bitcoin Beach, or Bitcoin Jungle user to be aware that the backend is using Galoy. Then in Alby, they would select Galoy, then choose which wallet they use, or "Connect to custom endpoint". Don't think that's a reasonable assumption though.

@secondl1ght
Copy link
Contributor Author

Should we create a new issue to track the connector re-design?

@bumi
Copy link
Collaborator

bumi commented Jan 25, 2022 via email

@bumi bumi merged commit 2f39513 into getAlby:master Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants