New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change grid to allow 5 connectors per row #558
Conversation
whoot. you're fast. |
We won't have Galoy, as that's just the tech from what I understand. So it will be BitcoinBeach, and I think Bitcoin Jungle. @vindard is that correct? OR do those two apps share a database? Either way I reckon that list will continue to grow, and I'd opt we go for a more App Store style card. Similar to what Auwal did for the Websites tab. |
Check out the #434 branch. It is a Galoy connector. I like the app store style cards...those can hold enough information. |
but are you OK with this PR for this release? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I guess tbd because the only thing that separates these two is the api link we point at. |
A Galoy connector in Alby would then need the user Bitcoin Beach, or Bitcoin Jungle user to be aware that the backend is using Galoy. Then in Alby, they would select Galoy, then choose which wallet they use, or "Connect to custom endpoint". Don't think that's a reasonable assumption though. |
Should we create a new issue to track the connector re-design? |
👍 please do.
… On 25. Jan 2022, at 18:04, secondl1ght ***@***.***> wrote:
Should we create a new issue to track the connector re-design?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you were mentioned.
|
@bumi wanted to have all on one row instead of having 1 connector by itself.