Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update citadel sdk for core lightning support #769

Merged
merged 1 commit into from
Apr 3, 2022

Conversation

AaronDewes
Copy link
Contributor

Type of change (Remove other not matching type)

  • Bug fix (non-breaking change which fixes an issue)

Describe the changes you have made in this PR -

This updates the Citadel SDK and makes a minor change that is required to support Core Lightning (previously called c-lightning) on Citadel in the future.

How Has This Been Tested?

I manually ensured everything was still working correctly when connected to my local Citadel.

Checklist:

  • My code follows the style guidelines of this project and performed a self-review of my own code
  • New and existing tests pass locally with my changes
  • I checked if I need to make corresponding changes to the documentation (and made those changes if needed)

@bumi
Copy link
Collaborator

bumi commented Apr 2, 2022

utACK.

in your the sdk code the MiddlewareLND now works for both lnd and cln?

(btw. slightly related thread: https://twitter.com/EricSirion/status/1509906940767481859 )

@escapedcat
Copy link
Contributor

@AaronDewes would you mind having a look at this?: #747
For some reason the jest setup has issues with the citadel-import. Maybe you have an idea what needs to be changed. If not no worries.

@AaronDewes
Copy link
Contributor Author

in your the sdk code the MiddlewareLND now works for both lnd and cln?

Yes, only the name is a leftover.

@AaronDewes
Copy link
Contributor Author

@AaronDewes would you mind having a look at this?: #747 For some reason the jest setup has issues with the citadel-import. Maybe you have an idea what needs to be changed. If not no worries.

It seems to be because we use ESM in @runcitadel/sdk, but Alby doesn't use it otherwise

@bumi
Copy link
Collaborator

bumi commented Apr 2, 2022

@escapedcat #747 is independent of this, correct?
so we can merge this one?

@escapedcat
Copy link
Contributor

@escapedcat #747 is independent of this, correct?
so we can merge this one?

Yup, all good here

@bumi bumi merged commit 6516983 into getAlby:master Apr 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants