Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent duplicate onboarding / configuration #806

Merged

Conversation

stefanwuest
Copy link
Contributor

Link this PR to an issue

Fixes #180

Type of change (Remove other not matching type)

  • Bug fix (non-breaking change which fixes an issue)

Describe the changes you have made in this PR -

So far, users were able to navigate to /welcome.html and complete the onboarding process again, even after the setup was completed. This change redirects the user to /options.html when the onboarding was already completed. I also changed redirecting the current tab, instead of creating a new one and closing the current one, which should be a less "flashy" experience for the user.

Screenshots of the changes (If any) -

How Has This Been Tested?

I tested on Chrome.
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

  • My code follows the style guidelines of this project and performed a self-review of my own code
  • New and existing tests pass locally with my changes
  • I checked if I need to make corresponding changes to the documentation (and made those changes if needed)

@bumi
Copy link
Collaborator

bumi commented Apr 20, 2022

great, thanks for the PR.
looks good to me. using the redirect would mean that the user "looses" the currently open tab, doesn't it?

@stefanwuest
Copy link
Contributor Author

stefanwuest commented Apr 20, 2022

great, thanks for the PR. looks good to me. using the redirect would mean that the user "looses" the currently open tab, doesn't it?

yes, you are right, this actually just makes sense for the case where the onboarding was already completed (it makes sense there, because you'll only enter the welcome.html through direct input). will adapt.

Copy link
Collaborator

@bumi bumi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

thanks!

@bumi bumi merged commit cd87f46 into getAlby:master Apr 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prevent onboarding process from being executed multiple times
2 participants