feat: replace invoices by bolt11 #830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bumi
approved these changes
Apr 27, 2022
| description={invoiceRef.current?.description} | ||
| amount={invoiceRef.current?.satoshis} | ||
| description={ | ||
| invoiceRef.current?.tags.find( |
There was a problem hiding this comment.
this is what I did not like about the bolt11 package. There is no easy way to get the description (which probably most will need)
maybe we should make a PR to get a proper accessor for that? invoiceRef.current.description ? This should do the lookup then in the bolt11 package.
There was a problem hiding this comment.
I agree, this feels rather cumbersome. Let's try a PR
There was a problem hiding this comment.
I opened a PR: bitcoinjs/bolt11#60
|
bolt11 decode got updated :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link this PR to an issue
Fixes #809
Type of change (Remove other not matching type)
Describe the changes you have made in this PR -)
Replaced the invoices lib by bolt11
PS: needs to be tested thoroughly