Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update invoice expiration date to one week #305

Closed
wants to merge 1 commit into from

Conversation

reneaaron
Copy link
Contributor

Fixes #304

@bumi
Copy link
Contributor

bumi commented Feb 13, 2023

can you describe why? (best actually in the commit message)

@kiwiidb
Copy link
Contributor

kiwiidb commented Feb 13, 2023

In any case I would rather like to see this as part of the config, with a default that is the same as what we want to run in production after we've agreed on it.

@reneaaron
Copy link
Contributor Author

There are also other aspects to the invoice expiration that I didn't consider. (the expiration window allows you to limit exchange rate risks, e.g. when you send an invoice to a client)

I don't see an immediate reason to change something here.

@reneaaron reneaaron closed this May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Increase invoice expiration
3 participants