Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase invoice expiration #304

Open
reneaaron opened this issue Feb 13, 2023 · 2 comments
Open

Increase invoice expiration #304

reneaaron opened this issue Feb 13, 2023 · 2 comments
Assignees

Comments

@reneaaron
Copy link
Contributor

reneaaron commented Feb 13, 2023

We see quite some errors in our logs that arise from expired invoices being paid. While those cases are rare (compared to the total number of transactions), they are a nightmare for users:

  • They created an invoice and sent it to a friend via DM
  • Their friend wanted to pay the next day but received an error during the payment
  • Now they have to start over again: create a fresh invoice, send it to them (and remind them to pay within 24 hours)

From a user perspective I would argue that it isn't very understandable that an invoice expires at all.

Raising this default expiration limit won't solve the problem fundamentally, nevertheless I think it would still be an improvement for quite a lot of the cases:

Telling from our logs approximately 95% of the errors would disappear if we raise the limit to one week.

@reneaaron reneaaron self-assigned this Feb 13, 2023
@bumi
Copy link
Contributor

bumi commented Feb 13, 2023

why? I would rather reduce it.

@reneaaron
Copy link
Contributor Author

Updated the issue description and added some quick analysis about the impact from our error logs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants