fix: Allow unexpected returns #1704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AppMap runtime code review
|
dividedmind
approved these changes
Apr 16, 2024
dividedmind
reviewed
Apr 16, 2024
| // This can happen in async contexts where the recording began in the middle | ||
| // of another async task. It's possible that the parent call was executed | ||
| // before the recording began. If this is the case, discard the return event. | ||
| return; |
There was a problem hiding this comment.
It would be good idea to raise a warning, but I'm not sure where it should go...
There was a problem hiding this comment.
I thought the same thing. The issue is that this is called in so many different contexts it felt wrong throwing a console.log in there, and we don't have any other logging abstraction.
There was a problem hiding this comment.
Yeah, good discussion but the main thing is to just not crash :-)
dustinbyrne
force-pushed
the
fix/allow-unexpected-returns
branch
from
46936c7
to
686635f
Compare
|
🎉 This PR is included in version @appland/models-v2.10.2 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version @appland/appmap-v3.137.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1703
I've manually pulled this change into IntelliJ to verify it'll load AppMaps which were previously malformed.