-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Allow unexpected returns #1704
Conversation
AppMap runtime code review
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NB, the last commit should probably come first (with modified message) so that all the commits build.
// This can happen in async contexts where the recording began in the middle | ||
// of another async task. It's possible that the parent call was executed | ||
// before the recording began. If this is the case, discard the return event. | ||
return; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be good idea to raise a warning, but I'm not sure where it should go...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought the same thing. The issue is that this is called in so many different contexts it felt wrong throwing a console.log
in there, and we don't have any other logging abstraction.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, good discussion but the main thing is to just not crash :-)
46936c7
to
686635f
Compare
🎉 This PR is included in version @appland/models-v2.10.2 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
🎉 This PR is included in version @appland/appmap-v3.137.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Resolves #1703
I've manually pulled this change into IntelliJ to verify it'll load AppMaps which were previously malformed.