Style tweak, dimming highlight color #528
Conversation
| @@ -4,6 +4,11 @@ | |||
| font-family: "Open Sans"; | |||
| } | |||
|
|
|||
| /* | |||
| @ Selection highlight: #40576D | |||
There was a problem hiding this comment.
This was like a quick access for testing color, since qss doesn't support declaring variables. Could be removed if you want it more cleaner.
| QHeaderView::section | ||
| { | ||
| background-color: #3A3939; | ||
| color: silver; | ||
| padding-left: 4px; | ||
| border: 1px solid #6c6c6c; | ||
| } |
There was a problem hiding this comment.
This section was duplicated, there are one exact definition with more attributes down below this style.qss file.
|
Nice one :) |
|
Looking good! At first it did give me the feeling that somehow it was "disabled" because of the dimmed color but likely it just needs some getting used to. What does it look like when a row is disabled? Or the widget is disabled? I always wondered whether we should make the Alternating Row color slightly subtler and easier to the eye? Any thoughts on that? |
Good question, here's my test, disabling row and widget 👇
It seems disabling widgets doesn't affect the highlight color, and the same result before this PR.
I have thought about that, too. And I vote yes on that. 👍 |
|
A quick test on dimming alternative row color (
From |
|
I like it. also with the dimming of the alternating colours. It's a bit softer which is always nice. |
|
Can we merge this ? 😃 |
Style tweak, dimming highlight color
What's changed
QHeaderView::section's color attribute so one could customize itBefore
After
Custom header section text color
Motivation
Although I did think about overriding styles from the config, but then I thought it could become a bit harder to develop GUI in style that everyone could adopt since what other sees would be different from mine. So I decide to push the change I need and have a open discuss to see if everyone feels okay with it.
It's not much but I think it could improve the overall color contrast for seeing icons and other things that are a bit more important than selections. Bright icon friendly style.☺️