Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update regex to match periods in GitHub URL #194

Merged
merged 1 commit into from
Jun 5, 2024
Merged

Update regex to match periods in GitHub URL #194

merged 1 commit into from
Jun 5, 2024

Conversation

sqwxl
Copy link
Contributor

@sqwxl sqwxl commented May 26, 2024

This fixes the issue described in #193 .

spr in the following screenshot is the current spr release (v1.3.5). _spr is the binary compiled with the proposed change.

image

@sqwxl sqwxl changed the title Update regex to match periods in github URL Update regex to match periods in GitHub URL May 26, 2024
jwatzman
jwatzman approved these changes Jun 4, 2024
View reviewed changes
Copy link
Contributor

@jwatzman jwatzman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I don't have access to my work laptop right now to actually merge this but will try to remember to do so later in the week.

@flooey
Copy link
Contributor

flooey commented Jun 5, 2024

No worries @jwatzman, I've got it.

@flooey flooey merged commit 9db4aee into spacedentist:master Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwatzman jwatzman jwatzman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sqwxl @flooey @jwatzman