Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spr doesn't recognize existing commits/PRs #193

Closed
sqwxl opened this issue May 25, 2024 · 0 comments
Closed

Spr doesn't recognize existing commits/PRs #193

sqwxl opened this issue May 25, 2024 · 0 comments

Comments

@sqwxl
Copy link
Contributor

sqwxl commented May 25, 2024

I'm not sure how I got here, because I've been using spr without issue so far (albeit only for a few days). But earlier, I went to update an upstream PR with spr diff, and instead of the expected update, spr behaved like it was seeing this commit for the first time and created a whole new PR for it.

I've tried all sorts of things, like closing all the upstream spr/ branches, pruning the remotes, re-running spr init, generating a new PAT, cloning the remote repo again. All with no success. Here's a screenshot of the type of behavior I'm seeing:

image

Update: The misbehavior is specific to the repository used in the screenshot...

Update 2: I've found that pointing spr in the same repository to a different upstream (a fresh GitHub repository with a different name in a different org) gets it working normally. So it looks like the problem might be related to the original upstream repository's settings.

Update 3: On a hunch, I removed the period, ., from the repository name and suddenly things are working again!

flooey pushed a commit that referenced this issue Jun 5, 2024
This fixes the issue described in #193 .

`spr` in the following screenshot is the current `spr` release (v1.3.5).
`_spr` is the binary compiled with the proposed change.


![image](https://github.com/getcord/spr/assets/55964909/e37d5864-295c-48bf-a288-c02b8464082d)
@sqwxl sqwxl closed this as completed Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant