Skip to content

Commit

Permalink
Update regex to match periods in GitHub URL (#194)
Browse files Browse the repository at this point in the history
This fixes the issue described in #193 .

`spr` in the following screenshot is the current `spr` release (v1.3.5).
`_spr` is the binary compiled with the proposed change.


![image](https://github.com/getcord/spr/assets/55964909/e37d5864-295c-48bf-a288-c02b8464082d)
  • Loading branch information
sqwxl authored Jun 5, 2024
1 parent 1e74fa1 commit 9db4aee
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion spr/src/config.rs
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ impl Config {
}

let regex = lazy_regex::regex!(
r#"^\s*https?://github.com/([\w\-]+)/([\w\-]+)/pull/(\d+)([/?#].*)?\s*$"#
r#"^\s*https?://github.com/([\w\-\.]+)/([\w\-\.]+)/pull/(\d+)([/?#].*)?\s*$"#
);
let m = regex.captures(text);
if let Some(caps) = m {
Expand Down

0 comments on commit 9db4aee

Please sign in to comment.