Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use empty strings for credentials if not defined in env vars #3

Merged
merged 1 commit into from
Oct 9, 2020
Merged

Use empty strings for credentials if not defined in env vars #3

merged 1 commit into from
Oct 9, 2020

Conversation

nickday
Copy link
Contributor

@nickday nickday commented Oct 8, 2020

Thanks for making this! I'm using it with Amplify in a Lambda resolver. It works fine in the cloud, but when mocking locally using amplify mock api the AWS credentials are not set and so it attempts to create credentials using undefined producing:

TypeError [ERR_INVALID_ARG_TYPE]: The "key" argument must be of type string or an instance of Buffer, TypedArray, DataView, or KeyObject. Received undefined

This change makes it fallback to empty strings instead, and mocking in Amplify now works 🎉

@amcdnl amcdnl merged commit a77091c into getcrft:master Oct 9, 2020
@amcdnl
Copy link
Contributor

amcdnl commented Oct 9, 2020

published

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants