iOS AppStore release 4.0.4 #113
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update ditto version
Android - Remove unused/broken functionality
Removed the twitter profile section/link (Out of scope and didn't work) as well as the ability to message someone from the profile page as this functionality was broken and out of scope.
Remove unused/broken functionality
Update app version
When cursor positioned at start of chat input text, cursor was too far to leading edge. - add small edge inset margin to chat input view, ExpandingTextView wrapper
|
The release issue #112 is related to this PR. (It appears to not be linkable through the Github UI, maybe because there is a merge conflict; however the conflict will not be resolved since this branch should not be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE TO MAIN
UI updates for AppStore release: positioning of the camera button in the chat thread view to conform with Apple's HIG.
This is a special release to get UI updates into the AppStore before merging the DQL migration release, which will be a breaking change.
This release branch is cut from
legacy-builder-apibranch for backward compatibility with the previous AppStore release which was cut fromlegacy-builder-api, which was created to preserve a legacy builder version of the codebase after the DQL migration was merged tomain.The UI update commits were merged to
mainwith the DQL migration branch still independent, but then it was noticed thatmainandlegacy-builder-apihad diverged, and the 4.0.3 AppStore release was no longer compatible with main. So the UI update commits were cherry-picked frommaintolegacy-builder-apiand this release cut from that.From here, the
legacy-builder-apibranch should be merged toDQLbranch and thoroughly tested along with the Android version in this same repo. Only after QA is satisfied on and between both platform versions shouldDQLbe merged tomain. From main then can be cut v5.0.0, a major, backwards-incompatible, release.