Features/tls auth #112
Merged
Features/tls auth #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NOTE: This implementation will only work for OpenSSL v1.0.2 and later. Doing it for earlier versions is totally insane: https://wiki.openssl.org/index.php/Hostname_validation
wtoorop
added a commit
that referenced
this pull request
Sep 4, 2015
…ls_auth"" This reverts commit 6d29e60.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add strict TLS authentication using hostname.
User must specify the hostname of the upstream (using tls_auth_name) as now TLS will use it to try to authenticate the server. If this fails then the TLS connection fails (a future update will add fallback to opportunistic TLS if authentication fails).
Note that getdns is coded to expect the trusted CA certificates to be in the default directory for the OS, as specified by the SSL_CTX_set_default_verify_paths() method. We should consider adding an option for the user to specify this path. This is a bit awkward on Mac OSX (see docs)...