Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🛠️ enhance/default banner and profile picture #1891

Open
wants to merge 9 commits into
base: develop
Choose a base branch
from

Conversation

tanjiralmamun
Copy link
Contributor

@tanjiralmamun tanjiralmamun commented May 23, 2023

All Submissions:

  • My code follows the WordPress' coding standards
  • My code satisfies feature requirements
  • My code is tested
  • My code passes the PHPCS tests
  • My code has proper inline documentation
  • I've included developer documentation (optional)
  • I've added proper labels to this pull request

Changes proposed in this Pull Request:

Closes #1795.

How to test the changes in this Pull Request:

Changelog entry

Enter a summary of all changes on this Pull Request. This will appear in the changelog if accepted.

PR Self Review Checklist:

  • Code is not following code style guidelines
  • Bad naming: make sure you would understand your code if you read it a few months from now.
  • KISS: Keep it simple, Sweetie (not stupid!).
  • DRY: Don't Repeat Yourself.
  • Code that is not readable: too many nested 'if's are a bad sign.
  • Performance issues
  • Complicated constructions that need refactoring or comments: code should almost always be self-explanatory.
  • Grammar errors.

FOR PR REVIEWER ONLY:

As a reviewer, your feedback should be focused on the idea, not the person. Seek to understand, be respectful, and focus on constructive dialog.

As a contributor, your responsibility is to learn from suggestions and iterate your pull request should it be needed based on feedback. Seek to collaborate and produce the best possible contribution to the greater whole.

  • Correct — Does the change do what it’s supposed to? ie: code 100% fulfilling the requirements?
  • Secure — Would a nefarious party find some way to exploit this change? ie: everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities?
  • Readable — Will your future self be able to understand this change months down the road?
  • Elegant — Does the change fit aesthetically within the overall style and architecture?

@tanjiralmamun tanjiralmamun added Needs: Testing This requires further testing Needs: Dev Review It requires a developer review and approval labels May 23, 2023
@tanjiralmamun tanjiralmamun changed the title 📧 enhance/default banner and profile picture 🛠️ enhance/default banner and profile picture May 23, 2023
includes/Vendor/Vendor.php Outdated Show resolved Hide resolved
templates/store-header.php Outdated Show resolved Hide resolved
templates/store-lists-loop.php Outdated Show resolved Hide resolved
templates/store-lists-loop.php Outdated Show resolved Hide resolved
@nurul-umbhiya nurul-umbhiya added Needs: Author Reply and removed Needs: Dev Review It requires a developer review and approval labels May 24, 2023
@tanjiralmamun tanjiralmamun added Needs: Dev Review It requires a developer review and approval and removed Needs: Author Reply labels May 24, 2023
@nurul-umbhiya nurul-umbhiya added 👍 Dev Review Done and removed Needs: Dev Review It requires a developer review and approval labels May 26, 2023
@shashwatahalder01 shashwatahalder01 added QA In Progress and removed Needs: Testing This requires further testing labels May 26, 2023
@shashwatahalder01

This comment was marked as resolved.

@shashwatahalder01
Copy link
Contributor

Scenario:
No crop image option is available when uploading default banner/profile picture.
Follow vendor update procedures for banner/profile picture upload.

Steps to reproduce:

  1. upload default banner/profile picture from dokan > settings > appearance [no crop option is available]

Video & Screenshot:
https://www.awesomescreenshot.com/video/17822753?key=7f25d03c62ac2af1b0d66badc4a4be5d

Screenshot at May 29 15-01-45

@shashwatahalder01 shashwatahalder01 added Needs: Dev Review It requires a developer review and approval and removed 👍 Dev Review Done labels Jul 18, 2023
@nurul-umbhiya nurul-umbhiya removed the Needs: Dev Review It requires a developer review and approval label Jul 20, 2023
@nurul-umbhiya nurul-umbhiya added 👍 Dev Review Done Needs: Testing This requires further testing and removed Type: Bug labels Jul 20, 2023
@shashwatahalder01 shashwatahalder01 added QA approved This PR is approved by the QA team QA In Progress Needs: Testing This requires further testing and removed Needs: Testing This requires further testing QA approved This PR is approved by the QA team QA In Progress labels Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
In Progress The issues is being worked on Type: Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default Banner and Profile Pictures for Vendors
5 participants