Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement arrow format for grpc ingestion #1087

Merged
merged 11 commits into from
Mar 4, 2023

Conversation

v3g42
Copy link
Contributor

@v3g42 v3g42 commented Feb 28, 2023

  • grpc to support arrow and default adapters
  • include a bench for connectors.
  • include a test for grpc
Benchmarking ny_taxi/100000: Warming up for 3.0000 s▸▹▹▹▹ : 1000: 4,427.4986/s
ny_taxi/100000          time:   [855.06 ns 872.46 ns 892.08 ns]
                        change: [-12.990% -9.7588% -6.6010%] (p = 0.00 < 0.05)
                        Performance has improved.

@v3g42 v3g42 changed the title Feat/arrow types feat: implement arrow format for grpc ingestion Mar 4, 2023
@coveralls
Copy link

Pull Request Test Coverage Report for Build 4330523590

  • 443 of 695 (63.74%) changed or added relevant lines in 17 files are covered.
  • 465 unchanged lines in 22 files lost coverage.
  • Overall coverage decreased (-0.9%) to 76.337%

Changes Missing Coverage Covered Lines Changed/Added Lines %
dozer-admin/src/tests/connections.rs 1 2 50.0%
dozer-ingestion/src/errors.rs 0 1 0.0%
dozer-ingestion/src/connectors/object_store/connector.rs 0 2 0.0%
dozer-types/src/arrow_types/errors.rs 0 2 0.0%
dozer-types/src/ingestion_types.rs 2 5 40.0%
dozer-ingestion/src/connectors/mod.rs 11 15 73.33%
dozer-ingestion/src/connectors/grpc/adapter/arrow.rs 62 67 92.54%
dozer-ingestion/src/connectors/grpc/tests.rs 139 144 96.53%
dozer-ingestion/src/connectors/grpc/connector.rs 26 44 59.09%
dozer-ingestion/src/connectors/grpc/ingest.rs 18 51 35.29%
Files with Coverage Reduction New Missed Lines %
dozer-ingestion/src/connectors/object_store/connector.rs 1 58.06%
dozer-ingestion/src/connectors/object_store/table_reader.rs 1 96.91%
dozer-ingestion/src/test_util.rs 1 95.74%
dozer-sql/src/pipeline/planner/projection.rs 1 71.97%
dozer-types/src/models/api_endpoint.rs 1 14.29%
dozer-ingestion/src/connectors/postgres/tests/continue_replication_tests.rs 2 96.18%
dozer-sql/src/pipeline/projection/factory.rs 3 77.55%
dozer-cache/src/cache/index/mod.rs 4 95.24%
dozer-ingestion/src/connectors/postgres/schema/tests.rs 4 97.47%
dozer-admin/src/tests/connections.rs 6 56.84%
Totals Coverage Status
Change from base Build 4325955628: -0.9%
Covered Lines: 29072
Relevant Lines: 38084

💛 - Coveralls

@v3g42 v3g42 marked this pull request as ready for review March 4, 2023 10:28
@snork-alt snork-alt merged commit 1fc7c38 into getdozer:main Mar 4, 2023
@v3g42 v3g42 deleted the feat/arrow-types branch March 4, 2023 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants