Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Optimize cache insertion and query when schema is append only #1192

Merged
merged 3 commits into from Mar 9, 2023

Conversation

chubei
Copy link
Collaborator

@chubei chubei commented Mar 9, 2023

No description provided.

@chubei chubei requested a review from v3g42 March 9, 2023 06:48
@coveralls
Copy link

coveralls commented Mar 9, 2023

Pull Request Test Coverage Report for Build 4374848003

  • 60 of 89 (67.42%) changed or added relevant lines in 9 files are covered.
  • 299 unchanged lines in 12 files lost coverage.
  • Overall coverage decreased (-0.4%) to 71.12%

Changes Missing Coverage Covered Lines Changed/Added Lines %
dozer-storage/src/lmdb_multimap.rs 2 5 40.0%
dozer-orchestrator/src/cli/repl/sql.rs 0 5 0.0%
dozer-cache/src/cache/lmdb/cache/main_environment.rs 42 52 80.77%
dozer-storage/src/lmdb_database/lmdb_val.rs 4 15 26.67%
Files with Coverage Reduction New Missed Lines %
dozer-api/src/grpc/shared_impl/filter/mod.rs 1 91.89%
dozer-api/src/grpc/shared_impl/mod.rs 1 67.92%
dozer-api/src/grpc/typed/service.rs 2 71.38%
dozer-cache/src/cache/lmdb/utils.rs 2 98.04%
dozer-api/src/grpc/typed/tests/service.rs 4 96.99%
dozer-sql/src/pipeline/aggregation/count.rs 5 56.1%
dozer-cache/src/cache/lmdb/cache/query/handler.rs 15 72.68%
dozer-api/src/grpc/typed/helper.rs 23 55.07%
dozer-cache/src/cache/lmdb/cache/main_environment.rs 29 68.4%
dozer-orchestrator/src/cli/repl/sql.rs 33 0%
Totals Coverage Status
Change from base Build 4374793544: -0.4%
Covered Lines: 27355
Relevant Lines: 38463

💛 - Coveralls

@chubei chubei merged commit 69140d8 into main Mar 9, 2023
3 checks passed
@chubei chubei deleted the perf/append branch March 9, 2023 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants