Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose execution context details in hook #32

Merged
merged 3 commits into from
Feb 15, 2022

Conversation

vmatyus
Copy link
Contributor

@vmatyus vmatyus commented Feb 8, 2022

Relates to #5

In commit: ce4571d you can see a possible solution for this problem.

The changed func() also could be func(interface{}) instead specific type *m.ExecutionInfo like in case of Step struct.

@vmatyus vmatyus force-pushed the add-execution-info branch 2 times, most recently from bf1820c to 849528a Compare February 8, 2022 15:38
Veronika Matyus added 3 commits February 8, 2022 17:25
Signed-off-by: Veronika Matyus <veronika.matyus@ibm.com>
Signed-off-by: Veronika Matyus <veronika.matyus@ibm.com>
Signed-off-by: Veronika Matyus <veronika.matyus@ibm.com>
@vmatyus
Copy link
Contributor Author

vmatyus commented Feb 8, 2022

Our project would need this extension, so I would like to request your review.

@emlaver
Copy link

emlaver commented Feb 14, 2022

@sriv @zabil if you have a moment to review this work that would be greatly appreciated!

@sriv sriv merged commit 35050fc into getgauge-contrib:master Feb 15, 2022
@sriv
Copy link
Contributor

sriv commented Feb 15, 2022

Done, sorry about the delay. gauge-go 0.3.0 is released and is available in the releases page. gauge install go will take some time to update (cache refresh still to kick in).

Thank you for the changes @vmatyusGitHub !

@emlaver
Copy link

emlaver commented Feb 15, 2022

@sriv thank you for reviewing!

@vmatyus vmatyus deleted the add-execution-info branch February 15, 2022 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants