Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can not reference to Microsoft.Extensions.Primitives.dll #24

Closed
jiabiao opened this issue Jul 26, 2018 · 4 comments
Closed

Can not reference to Microsoft.Extensions.Primitives.dll #24

jiabiao opened this issue Jul 26, 2018 · 4 comments

Comments

@jiabiao
Copy link

jiabiao commented Jul 26, 2018

It can add any other third-party nuget packages. But for Microsoft.Extensions.Primitives, it will throw the System.IO.FileLoadException from Gauge.Dotnet.GaugeListener.

reproduct steps:

gauge init dotnet
dotnet add package Microsoft.Extensions.Primitives --version 2.1.1
dotnet restore
gauge run

image

@jiabiao
Copy link
Author

jiabiao commented Jul 27, 2018

I guess this is beacuse gauge-dotnet already referenced to Microsoft.Extensions.Primitives 2.0.0
image

@jiabiao jiabiao changed the title Can not reference Microsoft.Extensions.Primitives.dll Can not reference to Microsoft.Extensions.Primitives.dll Jul 28, 2018
@BugDiver
Copy link
Member

BugDiver commented Aug 1, 2018

@jiabiao After some investigation, I found out that we reference a package named NLog.Extensions.Logging which refers to Microsoft.Extensions.Primitives.dll.

<PackageReference Include="NLog.Extensions.Logging" Version="1.0.0-rtm-rc5" />

We can get rid of NLog.Extensions.Logging since it is not used anywhere.

@BugDiver
Copy link
Member

BugDiver commented Aug 1, 2018

The fix should be available in nightly >= 01-08-2018.

@sswaroopgupta
Copy link

Verified in

Gauge version: 1.0.1.nightly-2018-07-31
Commit Hash: 4ae7c9a

Plugins
-------
dotnet (0.1.1.nightly-2018-08-01)

@ghost ghost removed the ready for QA label Aug 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

4 participants