Fix issues with long java classpath on Windows platform #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…length limitations on Windows
BugDiver
reviewed
Jul 18, 2017
gauge-java.go
Outdated
| cmd := exec.Command(cmdName, args...) | ||
| cmd.Stdout = os.Stdout | ||
| cmd.Stderr = os.Stderr | ||
| env := os.Environ() | ||
| env = append(env, fmt.Sprintf("CLASSPATH=%s", classpath)) | ||
| cmd.Env = env |
There was a problem hiding this comment.
@mdolinin If the CLASSPATH env already exists then it should overwrite it but currently it will append multiple CLASSPATH to environment. You can use os.Setenv to add CLASSPATH env and exec.Command will inherit that.
There was a problem hiding this comment.
Thanks for help. Fixed in next commit.
|
@BugDiver Sure. Signed. Thanks for help. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Windows platform has limitation on Maximum Path Length (https://msdn.microsoft.com/en-us/library/windows/desktop/aa365247(v=vs.85).aspx)
This cause problem with starting Gauge execution in java projects with long classpath
To fix this issue we can set the CLASSPATH as an environment variable
This fix will resolve:
getgauge/gauge#156
getgauge/gauge#184
getgauge/Intellij-Plugin#277
getgauge/Intellij-Plugin#164
getgauge/Intellij-Plugin#277