Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump com.google.protobuf:protobuf-java from 3.25.3 to 4.27.1 #815

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jun 10, 2024

Bumps com.google.protobuf:protobuf-java from 3.25.3 to 4.27.1.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file java Pull requests that update Java code labels Jun 10, 2024
@chadlwilson chadlwilson marked this pull request as draft June 10, 2024 04:44
@dependabot dependabot bot force-pushed the dependabot/maven/com.google.protobuf-protobuf-java-4.27.1 branch from 7dc772a to d788a3e Compare June 10, 2024 04:46
Bumps [com.google.protobuf:protobuf-java](https://github.com/protocolbuffers/protobuf) from 3.25.3 to 4.27.1.
- [Release notes](https://github.com/protocolbuffers/protobuf/releases)
- [Changelog](https://github.com/protocolbuffers/protobuf/blob/main/protobuf_release.bzl)
- [Commits](https://github.com/protocolbuffers/protobuf/commits)

---
updated-dependencies:
- dependency-name: com.google.protobuf:protobuf-java
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/maven/com.google.protobuf-protobuf-java-4.27.1 branch from d788a3e to fbb497e Compare June 17, 2024 07:38
Signed-off-by: Zabil Cheriya Maliackal <zabilcm@gmail.com>
@zabil zabil marked this pull request as ready for review June 17, 2024 09:54
@zabil
Copy link
Member

zabil commented Jun 17, 2024

Upgraded the proto generated files to use the latest version using genproto.sh

@zabil
Copy link
Member

zabil commented Jun 17, 2024

It also might be worth bumping up the version and making a release. Can add a commit for that in this PR.

@chadlwilson
Copy link
Contributor

Yeah the major version change and the dependencies with protobufs combined with major version change was main reason I didn't merge this. Didn't spend any time though :)

Was worried it might somehow end up coupled with a gauge release as don't have a sufficient depth of understanding about compatibility. :)

@zabil
Copy link
Member

zabil commented Jun 17, 2024

The functional tests pass. I can test this locally see if it works with the latest version of gauge. There is an option to make it only compatible/require the latest version of gauge.

Signed-off-by: Zabil Cheriya Maliackal <zabilcm@gmail.com>
@zabil zabil added the ReleaseCandidate If a PR is tagged with this label, after merging it will be released label Jun 17, 2024
@gaugebot
Copy link

gaugebot bot commented Jun 17, 2024

@dependabot[bot] Thank you for contributing to gauge-java. Your pull request has been labeled as a release candidate 🎉🎉.

Merging this PR will trigger a release.

Please bump up the version as part of this PR.

Instructions to bump the version can found at CONTRIBUTING.md

If the CONTRIBUTING.md file does not exist or does not include instructions about bumping up the version, please looks previous commits in git history to see what changes need to be done.

@zabil
Copy link
Member

zabil commented Jun 17, 2024

Bumped version and compatibility at d8bcbfc

Tested locally with

java --version                                                                                       11:56:28
openjdk 22.0.1 2024-04-16
OpenJDK Runtime Environment Homebrew (build 22.0.1)
OpenJDK 64-Bit Server VM Homebrew (build 22.0.1, mixed mode, sharing)

gauge -v                                                                                             11:56:24
Gauge version: 1.6.7
Plugins
-------
html-report (4.3.1)
java (0.11.0)
js (4.0.1)
screenshot (0.2.0)
ts (0.3.2)

@zabil zabil self-assigned this Jun 17, 2024
@zabil zabil merged commit 824aabf into master Jun 18, 2024
13 checks passed
@zabil zabil deleted the dependabot/maven/com.google.protobuf-protobuf-java-4.27.1 branch June 18, 2024 07:09
@zabil
Copy link
Member

zabil commented Jun 18, 2024

Had to manually push version 0.11.0 to gauge repositories because the sonatype repo tokens expired. I set the new tokens so the next build should be ok.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file java Pull requests that update Java code ReleaseCandidate If a PR is tagged with this label, after merging it will be released
Development

Successfully merging this pull request may close these issues.

None yet

2 participants