Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require Node 16+ while building/testing on Node 20 #596

Merged
merged 3 commits into from
Sep 26, 2023
Merged

Require Node 16+ while building/testing on Node 20 #596

merged 3 commits into from
Sep 26, 2023

Commits on Sep 25, 2023

  1. Use canonical encoding/readFile command to take advantage of fast pat… 

    …h in Node 20

Fast path doesn't appear to check encoding options case insensitive, 'utf8' seems more canonical.

Signed-off-by: Chad Wilson <chadw@thoughtworks.com>
    @chadlwilson
    chadlwilson committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    97cfa57 View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2023

  1. Apply workaround for mock-fs Node 20 issue 

    See tschaub/mock-fs#377

Signed-off-by: Chad Wilson <chadw@thoughtworks.com>
    @chadlwilson
    chadlwilson committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    39b152f View commit details
    Browse the repository at this point in the history

  2. Migrate build to Node 20 

    Node 16 is nearly EOL, and Node 20 is nearly LTS, so let's go straight there. This remove use of a deprecated npm flag, replacing with alternative compatible with npm 7/NodeJS 16 onwards (2021+, Node 16 recently went EOL in Sep 2023). The package-lock is also now only compatible with Node 16/npm 7 onwards.

Since this is technically a breaking change in npm/node compatibility, bumps the major version and updates the documentation as such.

Signed-off-by: Chad Wilson <chadw@thoughtworks.com>
    @chadlwilson
    chadlwilson committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    ea9086a View commit details
    Browse the repository at this point in the history