Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require Node 16+ while building/testing on Node 20 #596

Merged
merged 3 commits into from
Sep 26, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ jobs:
- name: Set up Nodejs
uses: actions/setup-node@v3
with:
node-version: 16
node-version: 20

- name: Setup submodule
run: |
Expand Down Expand Up @@ -51,7 +51,7 @@ jobs:
- name: Set up Nodejs
uses: actions/setup-node@v3
with:
node-version: 16
node-version: 20

- name: Setup java
uses: actions/setup-java@v3
Expand Down Expand Up @@ -99,7 +99,7 @@ jobs:
- name: Use Node.js
uses: actions/setup-node@v3
with:
node-version: 16
node-version: 20

- name: Setup go 1.20.x
uses: actions/setup-go@v4
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
- name: Set up Nodejs
uses: actions/setup-node@v3
with:
node-version: 16
node-version: 20

- name: Setup git
run: |
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ The plugin is authored in [Javascript](https://en.wikipedia.org/wiki/JavaScript)
Gauge is authored in golang. These are independent processes talking to each other over TCP on port GAUGE_INTERNAL_PORT (env variable) using [Protobuf](https://github.com/getgauge/gauge-proto).

##### Pre-Requisites
* [Node.js](https://nodejs.org/en/) - Version >= 12
* [Node.js](https://nodejs.org/en/) - Version >= 16
* [Npm](https://www.npmjs.com/get-npm)

##### Compiling
Expand Down
4 changes: 2 additions & 2 deletions index.js
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
#! /usr/bin/env node

var version = process.versions.node.split(".");
if (parseInt(version[0]) === 0 && parseInt(version[1]) < 12) {
throw new Error("gauge-js requires Node.js version 0.12+. Current version: " + process.versions.node);
if (parseInt(version[0]) < 16) {
throw new Error("gauge-js requires Node.js version 16+. Current version: " + process.versions.node);
}

var fs = require("fs"),
Expand Down
8 changes: 4 additions & 4 deletions js.json
Original file line number Diff line number Diff line change
Expand Up @@ -19,19 +19,19 @@
"windows": [
"npm",
"install",
"--production",
"--omit=dev",
"--silent"
],
"darwin": [
"npm",
"install",
"--production",
"--omit=dev",
"--silent"
],
"linux": [
"npm",
"install",
"--production",
"--omit=dev",
"--silent"
]
},
Expand All @@ -51,7 +51,7 @@
"--init"
]
},
"version": "3.0.1",
"version": "4.0.0",
"gaugeVersionSupport": {
"minimum": "1.0.7",
"maximum": ""
Expand Down
Loading
Loading