Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

56 stop execution #69

Merged
merged 4 commits into from
Dec 8, 2017
Merged

56 stop execution #69

merged 4 commits into from
Dec 8, 2017

Conversation

sriv
Copy link
Member

@sriv sriv commented Dec 7, 2017

adds support for stopping execution, #56

@ghost ghost assigned sriv Dec 7, 2017
@ghost ghost added the in progress label Dec 7, 2017
@cla-bot cla-bot bot added the cla-signed label Dec 7, 2017
@nehashri nehashri self-requested a review December 7, 2017 08:54
src/extension.ts Outdated
@@ -52,8 +52,19 @@ export function activate(context: ExtensionContext) {
var notifyNewVersion = notifyOnNewGaugeVsCodeVersion(context,
extensions.getExtension(GAUGE_EXTENSION_ID)!.packageJSON.version);

context.subscriptions.push(vscode.commands.registerCommand(GaugeCommands.Execute, (args) => { execute(args, { inParallel: false }) }));
context.subscriptions.push(vscode.commands.registerCommand(GaugeCommands.ExecuteInParallel, (args) => { execute(args, { inParallel: false }) }));
let stopExecution = vscode.window.createStatusBarItem(vscode.StatusBarAlignment.Left, 2);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we move this to a function?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, good idea. Done.

@nehashri nehashri merged commit aefb3db into master Dec 8, 2017
@ghost ghost removed the in progress label Dec 8, 2017
@nehashri nehashri deleted the 56-stop-execution branch December 8, 2017 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants