Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Report screenshot failures clearly on report #257

Closed
zabil opened this issue Apr 15, 2020 · 1 comment
Closed

Report screenshot failures clearly on report #257

zabil opened this issue Apr 15, 2020 · 1 comment
Assignees
@NivedhaSenthil

Comments

@zabil
Copy link
Member

zabil commented Apr 15, 2020

Expected behavior

Clearly indicate that there was an error taking the screenshot using the default
screenshot handler in the screenshot sectionof the HTML when on headless environments.

Point to the relevant section of the documentation for implementing custom screenshot handlers.

Actual behavior

Blank screenshot

Steps to reproduce

  1. Initialize a gauge project (basic one without custom screenshot handler)
  2. Add a failing tests
  3. Run tests on docker

Gauge version

gauge -v
Gauge version: 1.0.7

Plugins
-------
dotnet (0.1.4)
html-report (4.0.10)
java (0.7.6)
js (2.3.10)
python (0.3.8)
ruby (0.5.3)
screenshot (0.0.1)
spectacle (0.1.4)
ts (0.0.5)
xml-report (0.2.3)
NivedhaSenthil added a commit that referenced this issue Jul 7, 2020
@NivedhaSenthil
#257 Show message to add custom screenshot
370195d 
Signed-off-by: Nivedha <nivedhasenthil@gmail.com>
NivedhaSenthil added a commit that referenced this issue Jul 7, 2020
@NivedhaSenthil
Show message to add custom screenshot #257
4205327 
Signed-off-by: Nivedha <nivedhasenthil@gmail.com>
Signed-off-by: NivedhaSenthil <nivedhasenthil@gmail.com>
NivedhaSenthil added a commit that referenced this issue Jul 7, 2020
@NivedhaSenthil
#257 Fix test to show message
242978d 
- when screenshot not available

Signed-off-by: NivedhaSenthil <nivedhasenthil@gmail.com>
@NivedhaSenthil NivedhaSenthil self-assigned this Jul 8, 2020
NivedhaSenthil added a commit that referenced this issue Jul 8, 2020
@NivedhaSenthil
#257 Show message to add custom screenshot (#268)
b3fedca 
* Show message to add custom screenshot #257

Signed-off-by: Nivedha <nivedhasenthil@gmail.com>
Signed-off-by: NivedhaSenthil <nivedhasenthil@gmail.com>

* #257 Fix test to show message

- when screenshot not available

Signed-off-by: NivedhaSenthil <nivedhasenthil@gmail.com>
@NivedhaSenthil
Copy link
Member

Fixed by #268

@zabil zabil mentioned this issue Jul 17, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NivedhaSenthil NivedhaSenthil

Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zabil @NivedhaSenthil