fix: allow one click access for html-report (#286) #287
Conversation
removing space character from timestamp based path to allow one click (cmd+click) access on the terminal of vs-code on macOS. Signed-off-by: Ahmet Geymen <ahmetgeymen@outlook.com>
ahmetgeymen
force-pushed
the
issue-286
branch
from
6d4e116
to
0a5f9b5
Compare
sriv
added
the
ReleaseCandidate
|
@ahmetgeymen Thank you for contributing to html-report. Your pull request has been labeled as a release candidate 🎉🎉. Merging this PR will trigger a release. Please bump up the version as part of this PR.Instructions to bump the version can found at CONTRIBUTING.md If the CONTRIBUTING.md file does not exist or does not include instructions about bumping up the version, please looks previous commits in git history to see what changes need to be done. |
|
@ahmetgeymen you can refer baa4f41 for reference on how to bump up versions. |
|
@zabil Actually latest release was tagged as v4.1.2 so I didn't think to bump up for 4.1.4. I thought this change might go with 4.1.3. I would bump up for 4.1.4 as you wish. |
Signed-off-by: Ahmet Geymen <ahmetgeymen@outlook.com>
ahmetgeymen
force-pushed
the
issue-286
branch
from
4656b46
to
bc3abad
Compare
|
Is there anything special to do for macOS and windows environment. It seems tests are failing for those OSs. |
|
I ran the tests locally on windows and macos, they passed for me. So I guess these are transient failures - rerun passed confirming this. Thanks for the pull request @ahmetgeymen ! |
Removing space character from timestamp based path to allow one click (cmd+click) access on the terminal of vs-code on macOS.
issue: #286