allow chrome options to be passed at runtime

[sriv]

Expected behavior

Should be able to pass chrome flags via taiko args, or as env variables. This is to ensure that the same script can be run on docker/local machine.

Actual behavior

The options need to be in code. Example:

await openBrowser({args:['--no-sandbox', '--disable-setuid-sandbox']});

This prevents the script to be run in multiple environments.

Versions

Paste `node` and `taiko` versions here.

node v10.10.0
taiko v0.2.0

[zabil]

This does not work for

$ env TAIKO_BROWSER_ARGS=--window-size=1024,768 npx taiko --observe sample.js

sample.js

const { openBrowser, closeBrowser } = require('taiko');
(async () => {
    try {
        await openBrowser();
        screenshot()
    } catch (error) {
        console.error(error);
    } finally {
        await closeBrowser();
    }
})();

Possibly because we split using commas. There are a few options like these that have command in them.