-
Notifications
You must be signed in to change notification settings - Fork 452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow chrome options to be passed at runtime #164
Labels
Comments
NivedhaSenthil
added a commit
that referenced
this issue
Apr 23, 2020
Signed-off-by: NivedhaSenthil <nivedhasenthil@gmail.com>
sriv
pushed a commit
that referenced
this issue
Apr 23, 2020
Signed-off-by: NivedhaSenthil <nivedhasenthil@gmail.com>
This does not work for
sample.js
Possibly because we split using commas. There are a few options like these that have command in them. |
negiDharmendra
added a commit
that referenced
this issue
May 13, 2020
…t be applied correctly. #164 Signed-off-by: Dharmendra Singh <dharmenn@thoughtworks.com>
negiDharmendra
added a commit
that referenced
this issue
May 13, 2020
…rgs which invalidates all the args after following that. #164 Signed-off-by: Dharmendra Singh <dharmenn@thoughtworks.com>
negiDharmendra
added a commit
that referenced
this issue
May 13, 2020
…#1252) * Fixed an issue wherein browser arg with a comma in its value would not be applied correctly. #164 Signed-off-by: Dharmendra Singh <dharmenn@thoughtworks.com> * Fixed an issue wherein setBrowserArg would inject '--' into browser args which invalidates all the args after following that. #164 Signed-off-by: Dharmendra Singh <dharmenn@thoughtworks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Expected behavior
Should be able to pass chrome flags via taiko args, or as env variables. This is to ensure that the same script can be run on docker/local machine.
Actual behavior
The options need to be in code. Example:
This prevents the script to be run in multiple environments.
Versions
The text was updated successfully, but these errors were encountered: