Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

write api takes a lot of time after completion #277

Closed
NivedhaSenthil opened this issue Nov 27, 2018 · 2 comments
Closed

write api takes a lot of time after completion #277

NivedhaSenthil opened this issue Nov 27, 2018 · 2 comments
Assignees

Comments

@NivedhaSenthil
Copy link
Member

(async () => {
    try {
        await openBrowser();
        await goto("google.com");
        await write("hi");
    } catch (e) {
        console.error(e);
    } finally {
        await closeBrowser();
    }
})();

write in the above script takes more than 30secs after the text is actually written.

@klaussilveira
Copy link

You might want to disable waitForNavigation, or tweak the timeouts: https://taiko.gauge.org/#write

NivedhaSenthil added a commit that referenced this issue Dec 18, 2018
- remove `network idle` wait
- wait for all requests on `goto`
- wait for dom changes
- remove `load event` wait as `first meaningful paint` takes care of it
NivedhaSenthil added a commit that referenced this issue Dec 18, 2018
- fix network call waiting
- remove listeners on closeBrower
- make default timeout 30s same like goto
- throw error on timeout
NivedhaSenthil added a commit that referenced this issue Dec 19, 2018
- wait for all requests
- wait for all frame load
NivedhaSenthil added a commit that referenced this issue Dec 19, 2018
NivedhaSenthil added a commit that referenced this issue Dec 20, 2018
NivedhaSenthil added a commit that referenced this issue Dec 20, 2018
NivedhaSenthil added a commit that referenced this issue Dec 21, 2018
Apoorva-GA added a commit that referenced this issue Dec 24, 2018
@NivedhaSenthil
Copy link
Member Author

Wait for navigation is optimised now. The unresolved promises were handled properly. Fix available in d29e749. Some more flow is tracked as part of #304.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

4 participants