Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

global config to set waitForNavigation #328

Closed
saikrishna321 opened this issue Jan 8, 2019 · 2 comments
Closed

global config to set waitForNavigation #328

saikrishna321 opened this issue Jan 8, 2019 · 2 comments
Assignees

Comments

@saikrishna321
Copy link
Member

Currently, we need to set waitForNavigation to false or set timeout for each taiko command. Would be good if we can the configuration globally.

await click("Add", { waitForNavigation: false });

@gaugebot gaugebot bot added the community label Jan 8, 2019
@nehashri nehashri added triage and removed community labels Jan 9, 2019
@negiDharmendra negiDharmendra self-assigned this Apr 19, 2019
@negiDharmendra
Copy link
Contributor

How about introducing an API setConfig which can be used to set global config.

Example: setConfig( { waitForNavigation: false } )

For now setConfig will have support for

retryInterval and retryTimeout will used when not provided to the exists method

@Debashis9012
Copy link
Contributor

This has been verified and found fixed with the version 6d41672

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

4 participants