Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose elementList instead of returning the elementWrapper from the selectors #808

Closed
11 tasks done
luciferankon opened this issue Sep 12, 2019 · 1 comment
Closed
11 tasks done

Expose elementList instead of returning the elementWrapper from the selectors #808

luciferankon opened this issue Sep 12, 2019 · 1 comment
Assignees
@nehashri

Comments

@luciferankon
Copy link
Contributor

luciferankon commented Sep 12, 2019 •
edited

For more information refer here
Selectors need to be modified

  • button
  • image
  • link
  • listitem
  • fileField
  • textBox
  • dropDown
  • checkBox
  • radioButton
  • text
  • $
@luciferankon luciferankon self-assigned this Sep 12, 2019
@luciferankon luciferankon mentioned this issue Sep 12, 2019
Closed
11 tasks
@BugDiver BugDiver removed their assignment Sep 16, 2019
@nehashri nehashri mentioned this issue Sep 16, 2019
Closed
luciferankon added a commit that referenced this issue Sep 16, 2019
@luciferankon
Modified selector button to return elementList #808
bbf31e2
luciferankon added a commit that referenced this issue Sep 17, 2019
@luciferankon
Modified selector image to return elementList #808
705aaf9
luciferankon added a commit that referenced this issue Sep 17, 2019
@luciferankon
Modified selector link to return elementList #808
5b885e4 
- get to take required arguments i.e. retryInterval, tag etc
- Fixed tests for image selector
- Used elements instead of get in button, image and link selector
luciferankon added a commit that referenced this issue Sep 18, 2019
@luciferankon
Modified selector fileField to return elementList #808
38ba414
luciferankon added a commit that referenced this issue Sep 19, 2019
@luciferankon
Modified selector textBox to return elementList #808
3e955aa 
- made get and exists async to restore backward compatibility
luciferankon added a commit that referenced this issue Sep 19, 2019
@luciferankon
reduce the timeout to 1 sec for doesn't exist check #808
416d953
luciferankon added a commit that referenced this issue Sep 25, 2019
@luciferankon
Modified selector dropDown to return elementList #808
8810dbc 
- passed eventEmitter to apis
- passed retryTimeout, retryInterval to exists, text, value also
luciferankon added a commit that referenced this issue Sep 26, 2019
@luciferankon
Modified selector checkBox to return elementList #808
e27673f 
- Throw error if there is no matching node
- Passed nodeId instead of element
- Returned nodeId from element
luciferankon added a commit that referenced this issue Oct 5, 2019
@luciferankon
Modified selector radioButton to return elementList #808
b30a9c7
@nehashri nehashri mentioned this issue Oct 7, 2019
Closed
luciferankon added a commit that referenced this issue Oct 7, 2019
@luciferankon
Modified selector text to return elementList #808
0b05b73
luciferankon added a commit that referenced this issue Oct 7, 2019
@luciferankon
Modified selector $ to return elementList #808
3853ebc
luciferankon added a commit that referenced this issue Oct 9, 2019
@luciferankon
Modified selector listItem to return elementList #808
9e500aa
luciferankon added a commit that referenced this issue Oct 9, 2019
@luciferankon
Run all unit tests #808
ee55f46 
- Passed nodeId instead of elements
- Used elements instead of get
luciferankon added a commit that referenced this issue Oct 9, 2019
@luciferankon
Refactored tests for get #808
23d2b34
luciferankon added a commit that referenced this issue Oct 10, 2019
@luciferankon
Fixing tests #808
9a951df 
- Return fallback elementList if no matching nodeIds are found
luciferankon added a commit that referenced this issue Oct 11, 2019
@luciferankon
Fixing FT's #808
b946e10 
- run lint
luciferankon added a commit that referenced this issue Oct 11, 2019
@luciferankon
Fix unit tests on linux #808
800ed2d
luciferankon added a commit that referenced this issue Oct 18, 2019
@luciferankon
Moved eventEmitter to helper.js and stopped passing it to getIfExists #…
32dbb35 
…808
luciferankon added a commit that referenced this issue Oct 18, 2019
@luciferankon
Logged the exception when no element found #808
6559932
luciferankon added a commit that referenced this issue Oct 18, 2019
@luciferankon
Extracted basic element wrapper generation in a method #808
74db9df
luciferankon added a commit that referenced this issue Nov 8, 2019
@luciferankon
returned empty value for .text() if no element exists #808
6ca6522
@nehashri nehashri assigned nehashri and unassigned luciferankon Nov 13, 2019
luciferankon added a commit that referenced this issue Nov 20, 2019
@luciferankon
Added isChecked, check, uncheck to all the elements in elementList #808
9516fe6
luciferankon added a commit that referenced this issue Nov 20, 2019
@luciferankon
Added isSelected, select, deselect to all the elements in elementList…
4471157 
… for radiobutton #808
luciferankon added a commit that referenced this issue Nov 20, 2019
@luciferankon
Added value to all the elements of elementList in fileField #808
dbad27a
luciferankon added a commit that referenced this issue Nov 20, 2019
@luciferankon
Added value to all the elements of elementList in textBox #808
4e93def
NivedhaSenthil pushed a commit that referenced this issue Nov 29, 2019
@luciferankon @NivedhaSenthil
Migrated selectors to return elementList instead of elementWrapper (#880
d9a4b6a 
)

* Modified selector button to return elementList #808

* Modified selector image to return elementList #808

* Modified selector link to return elementList #808

- get to take required arguments i.e. retryInterval, tag etc
- Fixed tests for image selector
- Used elements instead of get in button, image and link selector

* Modified selector fileField to return elementList #808

* Modified selector textBox to return elementList #808

- made get and exists async to restore backward compatibility

* reduce the timeout to 1 sec for doesn't exist check #808

* Modified selector dropDown to return elementList #808

- passed eventEmitter to apis
- passed retryTimeout, retryInterval to exists, text, value also

* Modified selector checkBox to return elementList #808

- Throw error if there is no matching node
- Passed nodeId instead of element
- Returned nodeId from element

* Modified selector radioButton to return elementList #808

* Modified selector text to return elementList #808

* Modified selector $ to return elementList #808

* Modified selector listItem to return elementList #808

* Run all unit tests #808

- Passed nodeId instead of elements
- Used elements instead of get

* Refactored tests for get #808

* Fixing tests #808

- Return fallback elementList if no matching nodeIds are found

* Fixing FT's #808

- run lint

* Fix unit tests on linux #808

* Moved eventEmitter to helper.js and stopped passing it to getIfExists #808

* Logged the exception when no element found #808

* Extracted basic element wrapper generation in a method #808

* returned empty value for .text() if no element exists #808

* removing exists from list of elements in elementlist

* Added isChecked, check, uncheck to all the elements in elementList #808

* Added isSelected, select, deselect to all the elements in elementList for radiobutton #808

* Added value to all the elements of elementList in fileField #808

* Added value to all the elements of elementList in textBox #808

* implement text to throw error if element is not found

* refactioring. use .elements instead of getifexists

* adding select and value to elements in elementList for dropdown

* used elements instead of get for textMatch

* refactoring. moving around functions.

* refactoring. element.get() is now a sync fucntion

* refactoring. removing unused params, passing nodeId to evaluate

* adding todos. updating docs
@Debashis9012
Copy link
Contributor

This enhancement has been tested.
Tested version: ff140a8a5a76be5be2b7d1a82f04bdab27ac91d0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nehashri nehashri

Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@nehashri @BugDiver @luciferankon @Debashis9012