-
Notifications
You must be signed in to change notification settings - Fork 452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Color API #1117
Support for Color API #1117
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@saikrishna321 Few scenarios which I think can be addressed
- Using
select
with no parameter throws an exception which is not user-friendly
Thrown:
Cannot destructure property `stack` of 'undefined' or 'null'.
- Using
select
with invalid color code (hashcode or rgb/rgba) returns success but it does not select the color since it's invalid
> c.select('asda')
✔ Selected asda
> c.select('rgb()')
✔ Selected rgb()
> c.select('rgb(asdsd)')
✔ Selected rgb(asdsd)
@BugDiver What error message would you recommend? |
|
Also, about
I'm not sure if it's possible but if we could validate that the given input is a valid color code that would great. For Ex:
|
Fixes #1032