Reference type declarations in package.json #1278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It has nothing to do with this PR but I noticed that the CLA link here https://github.com/getgauge/taiko/blob/master/CONTRIBUTING.md#how-do-i-start-contributing is broken so I have no chance to sign it: |
* Make type definitions to be correctly resolved Signed-off-by: sceee <sceee@users.noreply.github.com>
IndraSaaki
approved these changes
May 21, 2020
Taiko now uses DCO's instead of CLA. And it looks like you've signed your commits which is good enough. I've updated the contribution instructions to reflect that. Thanks for pointing that out. |
NivedhaSenthil
approved these changes
May 22, 2020
RobertBeilich
added a commit
to RobertBeilich/taiko
that referenced
this pull request
Sep 23, 2020
Types are automatically inferred as of getgauge#1278
RobertBeilich
added a commit
to RobertBeilich/taiko
that referenced
this pull request
Sep 23, 2020
Types are automatically inferred as of getgauge#1278 Signed-off-by: Robert Beilich <robert@beilich.de>
NivedhaSenthil
added a commit
that referenced
this pull request
Sep 25, 2020
* Fix return type of getCookies Signed-off-by: Robert Beilich <robert@beilich.de> * Remove hint about experimental types Types are automatically inferred as of #1278 Signed-off-by: Robert Beilich <robert@beilich.de> * Add missing RelativeSearchElement types Signed-off-by: Robert Beilich <robert@beilich.de> * Add missing InterceptRequest attributes to type Signed-off-by: Robert Beilich <robert@beilich.de> Co-authored-by: Nivedha <nivedhasenthil@gmail.com>
saikrishna321
pushed a commit
to saikrishna321/taiko
that referenced
this pull request
Sep 28, 2020
* Fix return type of getCookies Signed-off-by: Robert Beilich <robert@beilich.de> * Remove hint about experimental types Types are automatically inferred as of getgauge#1278 Signed-off-by: Robert Beilich <robert@beilich.de> * Add missing RelativeSearchElement types Signed-off-by: Robert Beilich <robert@beilich.de> * Add missing InterceptRequest attributes to type Signed-off-by: Robert Beilich <robert@beilich.de> Co-authored-by: Nivedha <nivedhasenthil@gmail.com>
saikrishna321
pushed a commit
to saikrishna321/taiko
that referenced
this pull request
Sep 28, 2020
* Fix return type of getCookies Signed-off-by: Robert Beilich <robert@beilich.de> * Remove hint about experimental types Types are automatically inferred as of getgauge#1278 Signed-off-by: Robert Beilich <robert@beilich.de> * Add missing RelativeSearchElement types Signed-off-by: Robert Beilich <robert@beilich.de> * Add missing InterceptRequest attributes to type Signed-off-by: Robert Beilich <robert@beilich.de> Co-authored-by: Nivedha <nivedhasenthil@gmail.com>
saikrishna321
pushed a commit
to saikrishna321/taiko
that referenced
this pull request
Oct 1, 2020
* Fix return type of getCookies Signed-off-by: Robert Beilich <robert@beilich.de> * Remove hint about experimental types Types are automatically inferred as of getgauge#1278 Signed-off-by: Robert Beilich <robert@beilich.de> * Add missing RelativeSearchElement types Signed-off-by: Robert Beilich <robert@beilich.de> * Add missing InterceptRequest attributes to type Signed-off-by: Robert Beilich <robert@beilich.de> Co-authored-by: Nivedha <nivedhasenthil@gmail.com>
sswaroopgupta
pushed a commit
to sswaroopgupta/taiko
that referenced
this pull request
Oct 6, 2020
* Fix return type of getCookies Signed-off-by: Robert Beilich <robert@beilich.de> * Remove hint about experimental types Types are automatically inferred as of getgauge#1278 Signed-off-by: Robert Beilich <robert@beilich.de> * Add missing RelativeSearchElement types Signed-off-by: Robert Beilich <robert@beilich.de> * Add missing InterceptRequest attributes to type Signed-off-by: Robert Beilich <robert@beilich.de> Co-authored-by: Nivedha <nivedhasenthil@gmail.com> Signed-off-by: Soumya <soumya.swaroop@gmail.com>
saikrishna321
pushed a commit
to saikrishna321/taiko
that referenced
this pull request
Nov 1, 2020
* Fix return type of getCookies Signed-off-by: Robert Beilich <robert@beilich.de> * Remove hint about experimental types Types are automatically inferred as of getgauge#1278 Signed-off-by: Robert Beilich <robert@beilich.de> * Add missing RelativeSearchElement types Signed-off-by: Robert Beilich <robert@beilich.de> * Add missing InterceptRequest attributes to type Signed-off-by: Robert Beilich <robert@beilich.de> Co-authored-by: Nivedha <nivedhasenthil@gmail.com> Signed-off-by: saikrishna321 <saikrishna321@yahoo.com>
saikrishna321
pushed a commit
to saikrishna321/taiko
that referenced
this pull request
Jan 15, 2021
* Fix return type of getCookies Signed-off-by: Robert Beilich <robert@beilich.de> * Remove hint about experimental types Types are automatically inferred as of getgauge#1278 Signed-off-by: Robert Beilich <robert@beilich.de> * Add missing RelativeSearchElement types Signed-off-by: Robert Beilich <robert@beilich.de> * Add missing InterceptRequest attributes to type Signed-off-by: Robert Beilich <robert@beilich.de> Co-authored-by: Nivedha <nivedhasenthil@gmail.com> Signed-off-by: saikrishna321 <saikrishna321@yahoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It makes type definitions to be correctly resolved by IDEs. Without, taiko has no discoverable typedefs.
See https://www.typescriptlang.org/docs/handbook/declaration-files/publishing.html#including-declarations-in-your-npm-package for further explanation.