-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: stream workflow logs #379
Conversation
WalkthroughWalkthroughThe changes introduce enhanced logging capabilities across multiple crates, including new methods for emitting logs, updates to handle different log levels, and a new Changes
Sequence Diagram(s)sequenceDiagram
participant CLI_User as CLI User
participant CLI as CLI Application
participant JSONLMessenger as JSONLine Messenger
participant FormattedMessenger as Formatted Messenger
participant TransformedMessenger as Transformed Messenger
participant LogSystem as Log System
Note over CLI_User, LogSystem: Logging a Message Flow
CLI_User->>CLI: Trigger Log Event
CLI->>JSONLMessenger: emit_log(SimpleLogMessage)
JSONLMessenger->>LogSystem: debug(SimpleLogMessage)
CLI_User->>CLI: Trigger Log Event
CLI->>FormattedMessenger: emit_log(SimpleLogMessage)
FormattedMessenger->>LogSystem: Log based on LogLevel
CLI_User->>CLI: Trigger Log Event
CLI->>TransformedMessenger: emit_log(SimpleLogMessage)
TransformedMessenger->>LogSystem: Log based on LogLevel
Recent review detailsConfiguration used: .coderabbit.yaml Files selected for processing (9)
Files not reviewed due to errors (1)
Additional context usedLearnings (1)
Additional comments not posted (12)
Warning Review ran into problemsProblems (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
8 file(s) reviewed, no comment(s)
Expose hooks for emitting logs from workflows to Grit Cloud.
Greptile Summary
This is an auto-generated summary
workflow_server
dependency toserver
feature inCargo.toml
emit_log
method toJSONLineMessenger
injsonl.rs
emit_log
method toMessengerVariant
inmessenger_variant.rs
FormattedMessager
andTransformedMessenger
with new log levels andemit_log
inresult_formatting.rs
emit_log
method inMessager
trait inemit.rs
Summary by CodeRabbit
New Features
SimpleLogMessage
for structured logging with metadata support.TestingMessenger
.Improvements
AnalysisLogLevel
to include more traits for better serialization and copying.