-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Main page update #404
Main page update #404
Conversation
@@ -0,0 +1,83 @@ | |||
import React from 'react' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you do the imports for consistency with how I've been ordering them? Like this:
import React from 'react'
import Icon from 'react-fa'
import * as navigationActions from 'gModules/navigation/actions'
import * as Space from 'gEngine/space'
import * as User from 'gEngine/user'
import {formatDescription, formatDate} from 'gComponents/spaces/shared'
import arrowsVisibleImage from '../../../assets/metric-icons/blue/arrows-visible.png'
import './style.css'
Ordered by sections like this, new lines separating sections:
- React
- Redux
- NPM modules
- Internal components
- Internal selectors
- Internal actions
- Engine
- Internal libs
- servers
- Images
- Stylesheets
A new card layout for spaces. This is possible and more reasonable now that we have more space images. This impacts the main search page and the user pages, but does not yet impact that organizational pages.
Before
After