Migrate metric card names and value fields to use draft.js #425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…not go back in history
* master: Fixed a problem affecting dev where immutable invariants made space.organization a non-empty default object. Removing broken npm deploy rules. Using organization in favor of user wherever possible. Only check memberships if org id is present, else check creation.
|
|
||
| if (!item){ this.props.onEmptyCellMouseDown(e) } | ||
|
|
||
| if (inSelectedCell && !item){ |
| @@ -1,108 +1,118 @@ | |||
| import React, {Component, PropTypes} from 'react' | |||
|
|
|||
| import TextArea from 'react-textarea-autosize' | |||
There was a problem hiding this comment.
Don't need TextArea anymore, I think.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This in ways simplifies the codebase, will remove various bugs around the text fields, and will allow for much more functionality and control around the text areas.
Bug fixes/improvements