Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: support instanceName filtering for kubernetes auto-discovery deployment #2488

Merged
merged 4 commits into from Dec 17, 2023

Conversation

atropos112
Copy link
Contributor

@atropos112 atropos112 commented Dec 17, 2023

Proposed change

Add another annotation to kubernetes discovery to allow user to specify for which instance is this supposed to be present for. If no instance provided then it works for all instances preserving current behaviour.

Closes #2487

Type of change

  • New service widget
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation only
  • Other (please explain)

Checklist:

  • If applicable, I have added corresponding documentation changes.
  • If applicable, I have reviewed the feature and / or service widget guidelines.
  • I have checked that all code style checks pass using pre-commit hooks and linting checks.
  • If applicable, I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.

Copy link
Collaborator

@shamoon shamoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This certainly looks like it would work but double-checking, did you actually test it?

@shamoon shamoon changed the title Update service-helpers.js Enhancement: support instanceName filtering for kubernetes deployment Dec 17, 2023
docs/configs/kubernetes.md Outdated Show resolved Hide resolved
Co-authored-by: shamoon <4887959+shamoon@users.noreply.github.com>
@atropos112
Copy link
Contributor Author

atropos112 commented Dec 17, 2023

You are too quick for me 😉 I have now done testing and can confirm it works.

My testing was to build the image deploy on my cluster and see

  • having instance annotation matching my instanceName -> I can see it just fine (as expected)
  • having instance annotation not matching my instanceName -> I can't see it (as expected)
  • not having instance annotation -> I can see it just fine (as expected)

I have tested it on vivaldi (chrome based) and firefox, but I would be shocked if this is browser based

@shamoon
Copy link
Collaborator

shamoon commented Dec 17, 2023

Ha, sorry about that—no rush, but looks good =)

@shamoon shamoon enabled auto-merge (squash) December 17, 2023 17:58
@shamoon shamoon changed the title Enhancement: support instanceName filtering for kubernetes deployment Enhancement: support instanceName filtering for kubernetes auto-discovery deployment Dec 17, 2023
@shamoon shamoon merged commit eea20de into gethomepage:main Dec 17, 2023
5 checks passed
Copy link
Contributor

github-actions bot commented Feb 5, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants